Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RGBLight: Allow configurable default settings #11912

Merged
merged 2 commits into from
Feb 16, 2021
Merged

RGBLight: Allow configurable default settings #11912

merged 2 commits into from
Feb 16, 2021

Conversation

fauxpark
Copy link
Member

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team February 15, 2021 04:16
spidey3
spidey3 approved these changes Feb 15, 2021
View reviewed changes
Copy link
Contributor

@spidey3 spidey3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

spidey3
spidey3 requested changes Feb 15, 2021
View reviewed changes
Copy link
Contributor

@spidey3 spidey3 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just tried this out in my userspace, and found that there is a problem: the RGBLIGHT_MODE_... macros are not defined yet at the time that config.h is parsed, making it impossible to define RGBLIGHT_DEFAULT_MODE. The only workaround I could find was to #include "rgblight.h" in config.h before defining RGBLIGHT_DEFAULT_MODE, but after defining any RGBLIGHT_EFFECT... macros.

@spidey3
Copy link
Contributor

spidey3 commented Feb 15, 2021

I just tried this out in my userspace, and found that there is a problem...

Never mind. It turned out to be a typo in my code.

@spidey3 spidey3 merged commit 53b96f6 into qmk:develop Feb 16, 2021
@fauxpark fauxpark deleted the rgblight-configurable-defaults branch February 16, 2021 20:25
@fauxpark fauxpark mentioned this pull request Mar 6, 2021
Merged
6 tasks
@fauxpark fauxpark mentioned this pull request Apr 12, 2021
Merged
14 tasks
@fauxpark fauxpark mentioned this pull request Jun 29, 2021
Merged
14 tasks
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@fauxpark
RGBLight: Allow configurable default settings (qmk#11912)
00cb2c0 
* RGBLight: Allow configurable default settings

* Docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spidey3 spidey3 spidey3 approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
core documentation enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fauxpark @spidey3 @drashna